-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock #1105
Merged
MyonKeminta
merged 3 commits into
pingcap:master
from
MyonKeminta:m/check-txn-status-primary-mismatch
Apr 24, 2023
Merged
Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock #1105
MyonKeminta
merged 3 commits into
pingcap:master
from
MyonKeminta:m/check-txn-status-primary-mismatch
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyonKeminta
force-pushed
the
m/check-txn-status-primary-mismatch
branch
from
April 23, 2023 05:52
000d81f
to
527a227
Compare
Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
changed the title
Add new error type for indicating that check_txn_status is performed on non-primary
Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock
Apr 23, 2023
This was referenced Apr 23, 2023
Merged
zyguan
approved these changes
Apr 23, 2023
ekexium
approved these changes
Apr 24, 2023
Co-authored-by: ekexium <[email protected]>
This was referenced Apr 26, 2023
zyguan
added a commit
that referenced
this pull request
May 10, 2023
* Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (#1105) * Change implementation * Fix typo in comment Signed-off-by: MyonKeminta <[email protected]> * Update proto/kvrpcpb.proto Co-authored-by: ekexium <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: ekexium <[email protected]> * Add error type for primary mismatch (#1107) Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: ekexium <[email protected]>
MyonKeminta
added a commit
to MyonKeminta/kvproto
that referenced
this pull request
May 23, 2023
… lock on the key (if any) is a real primary lock (pingcap#1105) * Change implementation * Fix typo in comment Signed-off-by: MyonKeminta <[email protected]> * Update proto/kvrpcpb.proto Co-authored-by: ekexium <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: ekexium <[email protected]>
MyonKeminta
added a commit
that referenced
this pull request
May 24, 2023
…ith primary changed (#1120) * Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (#1105) Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: ekexium <[email protected]>
MyonKeminta
added a commit
to MyonKeminta/kvproto
that referenced
this pull request
Jun 29, 2023
…ith primary changed * Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (pingcap#1105) Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: ekexium <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pingcap/tidb#42937