Update perror code and regenerate perror.go #127
Conversation
| @@ -393,11 +396,11 @@ var MysqlErrNameToNum = map[string]int{ | |||
| "OBSOLETE_ER_FLUSH_MASTER_BINLOG_CLOSED": 1186, | |||
| "ErrIndexRebuild": 1187, | |||
| "OBSOLETE_ER_INDEX_REBUILD": 1187, | |||
| "ER_MASTER": 1188, | |||
| "ER_SOURCE": 1188, | |||
| "ErrMaster": 1188, | |||
There was a problem hiding this comment.
Should we create an issue in TiDB repo to clean up all these (unused?) error codes?
There was a problem hiding this comment.
You mean in pingcap/tidb? I don't think they are used there. I only found one in tests/integrationtest/t/privilege/privileges.test: --error ER_TABLEACCESS_DENIED_ERROR, which should be fine.
There was a problem hiding this comment.
I guess the ErrMaster comes from pingcap/tidb, and I would assume most of the similar errors mentioning Master or Slave are not in use in TiDB, so they could be removed from pingcap/tidb I guess?
There was a problem hiding this comment.
We could update those. But maybe we should then also try to replace master/slave in other places as well like dm-master.
Co-authored-by: Mattias Jonsson <[email protected]>
|
Not sure what's needed to get "license/cla" to report ✔️ |
https://cla.pingcap.net/pingcap/mysql-tester?pullRequest=127 says: Error There is no CLA to sign for pingcap/mysql-tester (could not find linked item for owner pingcap and repo mysql-tester) |
perror.go.For CI:
perror.goin CI.go.modinstead of a hardcoded one