Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: check remained lines after all test cases #132

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 4, 2024

Fix #131, add a extra line in show.result file,

➜  integrationtest git:(master) ✗ git diff
diff --git a/tests/integrationtest/r/show.result b/tests/integrationtest/r/show.result
index 42232d8bea..410b1425f5 100644
--- a/tests/integrationtest/r/show.result
+++ b/tests/integrationtest/r/show.result
@@ -3,3 +3,4 @@ show tables like '%xx';
 Tables_in_show (%xx)
 show databases like '%xx';
 Database (%xx)
+aa

the result shown below

➜  integrationtest git:(master) ✗ ./run-tests.sh -t show
extracting statistics: s
skip building portgenerator, using existing binary: ./portgenerator
start tidb-server, log file: ./integration-test.out
tidb-server(PID: 28692) started
run integration test cases(enabled new collation): show
ERRO[0001] run test [show] err: There is extra data at the end of the result file: aa


ERRO[0001] 1 tests failed
ERRO[0001] run test [show] err: There is extra data at the end of the result file: aa

// clear expected errors after we execute the first query
t.expectedErrs = nil

if err != nil {
Copy link
Contributor Author

@Defined2014 Defined2014 Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup check before.

Copy link
Collaborator

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Defined2014
Copy link
Contributor Author

/merge

@bb7133 bb7133 merged commit 314107b into pingcap:master Sep 4, 2024
2 checks passed
@Defined2014 Defined2014 deleted the fix-compare-result branch September 5, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When result file has more lines than result get from SQL, it wouldn't report error
3 participants