Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "using standard error code to replace terror (#982)" #1019

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Revert "using standard error code to replace terror (#982)" #1019

merged 1 commit into from
Sep 11, 2020

Conversation

imtbkcat
Copy link

Reverts #1014 because there is some compatibility issue

lysu
lysu reviewed Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 11, 2020
bobotu
bobotu approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@bobotu,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack).

@imtbkcat imtbkcat merged commit 2582971 into release-4.0 Sep 11, 2020
@kennytm kennytm deleted the revert-1014-stderr_40 branch September 11, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@bobotu bobotu bobotu approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @ti-srebot @lysu @bobotu