Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: add sql mode ALLOW_INVALID_DATES #171

Merged
merged 3 commits into from
Jan 14, 2019

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Jan 11, 2019

Required for pingcap/tidb#9027

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo
Copy link
Contributor

morgo commented Jan 12, 2019

Did you want to add a helper function, like HasNoAutoCreateUserMode? Most modes have one.

@kennytm kennytm added the status/LGT1 LGT1 label Jan 12, 2019
@bobotu
Copy link
Contributor Author

bobotu commented Jan 14, 2019

PTAL @morgo

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jan 14, 2019
@jackysp jackysp merged commit cf5695a into pingcap:master Jan 14, 2019
bobotu pushed a commit to bobotu/parser that referenced this pull request Jan 18, 2019
* mysql: add sql mode ALLOW_INVALID_DATES

* add HasAllowInvalidDatesMode
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* mysql: add sql mode ALLOW_INVALID_DATES

* add HasAllowInvalidDatesMode
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
* mysql: add sql mode ALLOW_INVALID_DATES

* add HasAllowInvalidDatesMode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants