Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql,terror: add plugin error msg #173

Merged
merged 4 commits into from
Jan 14, 2019
Merged

mysql,terror: add plugin error msg #173

merged 4 commits into from
Jan 14, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Jan 13, 2019

add plugin error message for pingcap/tidb#8788


This change is Reviewable

@lysu lysu changed the title mysql,terror: add plugin error msg. mysql,terror: add plugin error msg Jan 13, 2019
@tiancaiamao
Copy link
Collaborator

LGTM

@lysu lysu added the status/LGT1 LGT1 label Jan 13, 2019
@tiancaiamao
Copy link
Collaborator

Those errors is defined for TiDB only, and it's better to move it back to TiDB repo.
If Go2.0 error come out, I'll take the refactor into consideration...

mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
mysql/errname.go Outdated Show resolved Hide resolved
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit c5c6ec2 into pingcap:master Jan 14, 2019
@lysu lysu deleted the plugin-err-msg branch March 25, 2019 07:45
lysu added a commit that referenced this pull request Mar 25, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants