Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: minor fix of #198 #203

Merged
merged 3 commits into from
Feb 12, 2019
Merged

parser: minor fix of #198 #203

merged 3 commits into from
Feb 12, 2019

Conversation

exialin
Copy link
Contributor

@exialin exialin commented Feb 12, 2019

What problem does this PR solve?

Minor fix remained of PR #198.

@exialin
Copy link
Contributor Author

exialin commented Feb 12, 2019

@kennytm PTAL

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

ast/misc.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PTAL @leoppro

@kennytm kennytm added the status/LGT1 LGT1 label Feb 12, 2019
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit a0a2e58 into pingcap:master Feb 12, 2019
@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Feb 12, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants