Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far #252

Merged
merged 5 commits into from
Apr 2, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Help to fix share-rowid-bit problem. We should record the max share-rowid-bit has been used.

What is changed and how it works?

add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far.

Check List

Tests

Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

model/model.go Outdated Show resolved Hide resolved
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Apr 2, 2019
@kennytm kennytm merged commit 319ad86 into pingcap:master Apr 2, 2019
crazycs520 added a commit to crazycs520/parser that referenced this pull request May 13, 2019
…IDBits be used so far (pingcap#252)

* model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far

* address comment
crazycs520 added a commit that referenced this pull request May 13, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
…IDBits be used so far (pingcap#252)

* model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far

* address comment
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
…IDBits be used so far (pingcap#252)

* model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants