-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IDBits be used so far
xiekeyi98
reviewed
Apr 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winkyao
reviewed
Apr 1, 2019
winkyao
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crazycs520
added a commit
to crazycs520/parser
that referenced
this pull request
May 13, 2019
…IDBits be used so far (pingcap#252) * model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far * address comment
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
…IDBits be used so far (pingcap#252) * model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far * address comment
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
…IDBits be used so far (pingcap#252) * model: add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Help to fix share-rowid-bit problem. We should record the max share-rowid-bit has been used.
What is changed and how it works?
add MaxShardRowIDBits to table info to record the max ShardRowIDBits be used so far.
Check List
Tests