-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model: increase table and column version #254
Conversation
model/model.go
Outdated
// When we execute a change/modify column statement that does not specify a charset value for column, | ||
// we set the charset of this column to the charset of table. This behavior is compatible with MySQL. | ||
TableInfoVersion1 = uint16(1) | ||
// TableInfoVersion2 means the table info version is 2. | ||
// This is for v2.1.7 to identify new and old versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add some details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with zimulala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
This is for TiDB PR: pingcap/tidb#9820.
What is changed and how it works?
This PR increase table and column version.
Check List
Tests
Related changes