Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support syntax for 'admin reload expr_pushdown_blacklist' (#350) #368

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Jul 1, 2019

cherry-pick #350

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason previously approved these changes Jul 1, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the DNM label Jul 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Jul 1, 2019

hold on, we need more discussion for whether to merge this PR to release.2.1

@zz-jason zz-jason dismissed their stale review July 1, 2019 13:19

need more discussion

@XuHuaiyu XuHuaiyu removed the DNM label Jul 3, 2019
@zz-jason zz-jason merged commit 6286830 into pingcap:release-2.1 Jul 3, 2019
@XuHuaiyu XuHuaiyu deleted the release-2.1 branch July 3, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants