Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support "admin plugins enable/disable plugin" syntax #374

Merged
merged 1 commit into from
Jul 8, 2019
Merged

parser: support "admin plugins enable/disable plugin" syntax #374

merged 1 commit into from
Jul 8, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Jul 8, 2019

What problem does this PR solve?

support two new admin stmt:

admin plugins enable plugin1, plugin2;
admin plugins disable plugin3;

What is changed and how it works?

change parser

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • modify adminStmt and parser.y

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the 3.0 and 2.1

This change is Reviewable

@lysu lysu requested review from tiancaiamao and jackysp July 8, 2019 07:39
@codecov

This comment has been minimized.

@lysu
Copy link
Collaborator Author

lysu commented Jul 8, 2019

/rebuild

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants