Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: change default charset from utf8 to utf8mb4 (#13) #68

Merged
merged 1 commit into from
Dec 6, 2018
Merged

*: change default charset from utf8 to utf8mb4 (#13) #68

merged 1 commit into from
Dec 6, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 6, 2018 •
edited
Loading

cherry-pick from #13

Require for pingcap/tidb#8590

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

@tiancaiamao @zimulala PTAL

@winkyao winkyao mentioned this pull request Dec 6, 2018
Merged
zimulala
zimulala reviewed Dec 6, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 6, 2018
crazycs520
crazycs520 approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 80784c3 into pingcap:release-2.1 Dec 6, 2018
@winkyao winkyao deleted the 2.1-cherry-pick branch December 6, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/cherry-pick-for-release-2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winkyao @zimulala @crazycs520 @kennytm