Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charset: make collation case insensitive (#66) #70

Merged
merged 1 commit into from
Dec 7, 2018
Merged

charset: make collation case insensitive (#66) #70

merged 1 commit into from
Dec 7, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 6, 2018 •
edited
Loading

cherry-pick from #66

Required for pingcap/tidb#8611

@kennytm kennytm changed the title charsert: make collation case insensitive (#66) charset: make collation case insensitive (#66) Dec 6, 2018
@winkyao winkyao mentioned this pull request Dec 7, 2018
Merged
@zz-jason
Copy link
Member

zz-jason commented Dec 7, 2018

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Dec 7, 2018
jackysp
jackysp approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 6c21d43 into pingcap:release-2.1 Dec 7, 2018
@winkyao winkyao deleted the cherry-pick-2.1 branch December 7, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/cherry-pick-for-release-2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winkyao @zz-jason @jackysp