fix: add "UNDERSCORE_CHARSET hexLit/bitLit" in Literal #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 78.43% 78.40% -0.04%
==========================================
Files 40 40
Lines 14897 14805 -92
==========================================
- Hits 11685 11608 -77
+ Misses 2521 2506 -15
Partials 691 691 |
|
@kennytm,Thanks for your review. |
|
|
wangggong
force-pushed
the
underscore_charset_binhex_451
branch
from
1c86f66
to
00ef24a
Compare
Signed-off-by: wangggong <[email protected]>
wangggong
force-pushed
the
underscore_charset_binhex_451
branch
from
00ef24a
to
6c2efee
Compare
ti-srebot
previously approved these changes
Sep 10, 2020
|
@wangggong Please regenerate the |
@tangenta done, thx PTAL |
zimulala
approved these changes
Sep 15, 2020
ti-srebot
added
status/LGT3
ti-srebot
approved these changes
Sep 15, 2020
This was referenced Sep 29, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Signed-off-by: wangggong <[email protected]> Co-authored-by: Wang Ruichao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wang Ruichao [email protected]
What problem does this PR solve?
Close #451 , cc pingcap/tidb#14800
Bad SQL
What is changed and how it works?
Add "UNDERSCORE_CHARSET hexLit/bitLit" in Literal.
Check List
Tests