parser: add 'INSTANT' alter algorithm #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
reviewed
Jan 4, 2019
parser.y
Outdated
| @@ -1186,14 +1188,15 @@ AlterTableSpec: | |||
| { | |||
| $$ = &ast.AlterTableSpec{ | |||
| Tp: ast.AlterTableLock, | |||
| LockType: $1.(ast.LockType), | |||
| LockType: $1.(ast.LockType), | |||
tiancaiamao
reviewed
Feb 6, 2019
| @@ -3000,7 +3019,7 @@ TiDBKeyword: | |||
|
|
|||
| NotKeywordToken: | |||
| "ADDDATE" | "BIT_AND" | "BIT_OR" | "BIT_XOR" | "CAST" | "COPY" | "COUNT" | "CURTIME" | "DATE_ADD" | "DATE_SUB" | "EXTRACT" | "GET_FORMAT" | "GROUP_CONCAT" | |||
| | "INPLACE" | "INTERNAL" |"MIN" | "MAX" | "MAX_EXECUTION_TIME" | "NOW" | "RECENT" | "POSITION" | "SUBDATE" | "SUBSTRING" | "SUM" | |||
| | "INPLACE" | "INSTANT" | "INTERNAL" |"MIN" | "MAX" | "MAX_EXECUTION_TIME" | "NOW" | "RECENT" | "POSITION" | "SUBDATE" | "SUBSTRING" | "SUM" | |||
There was a problem hiding this comment.
INSTANT is a mysql keyword?
winkyao
force-pushed
the
add_alter_algorithm_instant
branch
from
4a769e4
to
115811a
Compare
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref pingcap/tidb#8428
Required for pingcap/tidb#8811