This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 275
Support Tiflash #1119
Merged
Support Tiflash #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubo0127
requested review from
marsishandsome
and removed request for
guliangliangatpingcap
January 14, 2020 03:21
liubo0127
commented
Jan 14, 2020
marsishandsome
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
liubo0127
added a commit
to liubo0127/tidb-ansible
that referenced
this pull request
Feb 18, 2020
* add tiflash config * Add tiflash * add deploy tiflash * update * fix some error * fix typo * optimize labels for tiflash * optimize format * reset some config (pingcap#1096) * Merge multiple configuration files and add status check (pingcap#1102) * update tiflash version (pingcap#1118) * Update roles/tiflash/tasks/main.yml * create status dir for all services Co-authored-by: Liangliang Gu <[email protected]>
liubo0127
added a commit
that referenced
this pull request
Feb 18, 2020
* Support Tiflash (#1119) * add tiflash config * Add tiflash * add deploy tiflash * update * fix some error * fix typo * optimize labels for tiflash * optimize format * reset some config (#1096) * Merge multiple configuration files and add status check (#1102) * update tiflash version (#1118) * Update roles/tiflash/tasks/main.yml * create status dir for all services Co-authored-by: Liangliang Gu <[email protected]> * rename theflash (#1128) * refactor tiflash config (#1136) * add tiflash proxy status port config (#1140) * tiflash add metrics port (#1144) * add tiflash conf in prometheus for tiflash dashboard (#1146) * add tiflash conf in prometheus for tiflash dashboard Co-authored-by: Liangliang Gu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marsishandsome PTAL