Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to new prow reviewing #1226

Merged
merged 2 commits into from
May 18, 2023
Merged

chore: migrate to new prow reviewing #1226

merged 2 commits into from
May 18, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 6, 2023 •
edited
Loading

What problem does this PR solve?

migrate to prow's builtin lgtm and approve for better community contribution.

Issue Number: close #1231

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@wuhuizuo wuhuizuo marked this pull request as ready for review May 8, 2023 11:58
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot May 15, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 72ee644

@ti-chi-bot ti-chi-bot bot merged commit 96a92db into master May 18, 2023
@wuhuizuo wuhuizuo deleted the feature/review-config branch June 6, 2023 08:19
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 6, 2023

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.1: #1242.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 6, 2023
Closed
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #1243.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Jun 6, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #1244.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#1226) (#1244)
a5d679c 
close #1231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
first-time-contributor size/M status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to prow lgtm + approve plugin for reviewing
4 participants
@wuhuizuo @ti-chi-bot @lance6716 @niubell