-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drainer: if all DML is filtered, return true
ignore
#1318
base: release-5.4
Are you sure you want to change the base?
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GMHDBJD: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please approve it after the PR merged. |
/hold |
/retest |
/run-unit-test |
/run-all-tests |
/unhold The PR is merged. |
/run-unit-test |
/run-integration-test |
unit test is still failing
|
Signed-off-by: lance6716 <[email protected]>
… into v5.4.3-fix1317
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #1317
What is changed and how it works?
don't append to
muts
if the whole transaction is filtered, so thatignore
istrue
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repositoryRelease note