Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: if all DML is filtered, return true ignore #1318

Open
wants to merge 4 commits into
base: release-5.4
Choose a base branch
from

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Sep 6, 2024

What problem does this PR solve?

Issue Number: close #1317

What is changed and how it works?

don't append to muts if the whole transaction is filtered, so that ignore is true

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

If the whole transaction is filtered, release the memory

Copy link

ti-chi-bot bot commented Sep 6, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 6, 2024

@GMHDBJD: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 6, 2024

Please approve it after the PR merged.

@lance6716
Copy link
Contributor Author

/hold

@lance6716
Copy link
Contributor Author

/retest

@lance6716
Copy link
Contributor Author

/run-unit-test

@lance6716
Copy link
Contributor Author

/run-all-tests

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 6, 2024

/unhold

The PR is merged.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 6, 2024
@lance6716
Copy link
Contributor Author

/run-unit-test

@lance6716
Copy link
Contributor Author

/run-integration-test

@kennytm
Copy link
Contributor

kennytm commented Sep 6, 2024

unit test is still failing

[2024-09-06T08:54:54.645Z] FAIL: syncer_test.go:35: syncerSuite.TestFilterTable

[2024-09-06T08:54:54.645Z] 

[2024-09-06T08:54:54.645Z] syncer_test.go:61:

[2024-09-06T08:54:54.645Z]     c.Assert(ignore, check.IsFalse)

[2024-09-06T08:54:54.645Z] ... obtained bool = true

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 03:27:45.755542744 +0000 UTC m=+240535.495966709: ☑️ agreed by D3Hunter.
  • 2024-09-09 05:30:41.538357089 +0000 UTC m=+247911.278781028: ☑️ agreed by GMHDBJD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants