Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade grpc to 1.23 #899

Merged
merged 1 commit into from
Feb 14, 2020
Merged

upgrade grpc to 1.23 #899

merged 1 commit into from
Feb 14, 2020

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

In https://github.com/pingcap/tidb/pull/14361/files grpc is upgraded from 1.17 to 1.27, so db can't no longer connect to the pump. see #804

What is changed and how it works?

pick #804
note there's compatible problem new version client can't connect to old version server.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Breaking backward compatibility

Related changes

  • Need to be included in the release note

@july2993
Copy link
Contributor Author

/run-all-tests

* go.mod: upgrade grpc to 1.23

* Fix  client blocks until it receives a SETTINGS frame from the server

* grpc.WithDialer is deprecated: use WithContextDialer instead.
@july2993
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit e52747e into pingcap:release-3.1 Feb 14, 2020
@july2993 july2993 deleted the grpc_up branch February 14, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants