Add E2E test for Statement #1196
Conversation
YiniXu9506
commented
Mar 14, 2022
YiniXu9506
commented
- add e2e test for statement list page and detail page;
- find a TiDB bug when testing search function on statement list page.
# Conflicts: # pkg/apiserver/slowquery/queries.go # pkg/apiserver/statement/service.go # ui/cypress/integration/slow_query/list.compat_spec.js
…geE2E # Conflicts: # ui/cypress/integration/slow_query/list.spec.js # ui/cypress/plugins/index.js # ui/lib/components/HighlightSQL/index.tsx
…istPage # Conflicts: # ui/package.json # ui/yarn.lock
…istPage # Conflicts: # ui/cypress/integration/slow_query/02-detail.spec.js # ui/lib/components/Expand/index.tsx
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
We can hold this PR for a moment, wait pingcap/tidb#33052 to be merged and test again. Meanwhile the code review can happen. cc @shhdgit @baurine |
|
|
||
| // Wait TiUP Playground | ||
| cy.exec('bash ../scripts/wait_tiup_playground.sh 1 300 &> wait_tiup.log') | ||
| restartTiUP() |
There was a problem hiding this comment.
Maybe we can stop all tiup components processes after the test to avoid process leaks. Though these processes will be killed before the next round of tests.
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 29.60% 22.34% -7.27%
==========================================
Files 288 164 -124
Lines 16968 14139 -2829
Branches 651 0 -651
==========================================
- Hits 5023 3159 -1864
+ Misses 11714 10749 -965
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…506/tidb-dashboard into addE2E_statementListPage
|
Maybe we can update the e2e test script later so that the tiup process can be stopped. The rest LGTM. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: b3a9ee8
|
* test: add use database filter and search function * test: add select columns test * fix: missing fields in slowquery * fix: lower case field names in tests * update * update tiup reboot * test: slow query available fields * test: move available fields tests to compatibility test * chore: remove test log * update slowquery * update slow query e2e test * update export slow query csv * add missing regex * update slow query table order * update apiURL * fix time-range selector * update comment * slow query detail * update slow query detail page e2e * update slow query detail page * add statement e2e test * update yarn.lock * update statement list * update statement list * update statement * update statement list * update statement list * update statement list * update statement * update statement list * update statement list * update statement * test statement * test statement * update statement * update statement * resolve comments * fix typo * update statement config * update statement default max size value * remove useless e2e data value Co-authored-by: Suhaha <[email protected]>
* test: add use database filter and search function * test: add select columns test * fix: missing fields in slowquery * fix: lower case field names in tests * update * update tiup reboot * test: slow query available fields * test: move available fields tests to compatibility test * chore: remove test log * update slowquery * update slow query e2e test * update export slow query csv * add missing regex * update slow query table order * update apiURL * fix time-range selector * update comment * slow query detail * update slow query detail page e2e * update slow query detail page * add statement e2e test * update yarn.lock * update statement list * update statement list * update statement * update statement list * update statement list * update statement list * update statement * update statement list * update statement list * update statement * test statement * test statement * update statement * update statement * resolve comments * fix typo * update statement config * update statement default max size value * remove useless e2e data value Co-authored-by: Suhaha <[email protected]>
