Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to new prow reviewing #1510

Merged
merged 4 commits into from
May 15, 2023
Merged

chore: migrate to new prow reviewing #1510

merged 4 commits into from
May 15, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 6, 2023

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #1510 (3b7a0c4) into master (b2dc1e3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   27.25%   27.25%           
=======================================
  Files          93       93           
  Lines       10097    10097           
=======================================
  Hits         2752     2752           
  Misses       7165     7165           
  Partials      180      180           
Flag Coverage Δ
backend_ut 27.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2dc1e3...3b7a0c4. Read the comment docs.

@wuhuizuo wuhuizuo marked this pull request as ready for review May 8, 2023 12:05
OWNERS Outdated Show resolved Hide resolved
OWNERS Outdated Show resolved Hide resolved
OWNERS Outdated Show resolved Hide resolved
OWNERS Outdated Show resolved Hide resolved
OWNERS Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 3b7a0c4
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6461c7f86580f40008cae07d
😎 Deploy Preview https://deploy-preview-1510--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for tidb-dashboard-for-dbaas ready!

Name Link
🔨 Latest commit 3b7a0c4
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard-for-dbaas/deploys/6461c7f80a63ce0008d8f458
😎 Deploy Preview https://deploy-preview-1510--tidb-dashboard-for-dbaas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

@SabaPing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SabaPing SabaPing merged commit 911ba08 into master May 15, 2023
@SabaPing SabaPing deleted the feature/review-config branch May 15, 2023 05:59
baurine pushed a commit that referenced this pull request Jun 7, 2023
* chore: migrate to new prow reviewing

- Backgroup: https://internals.tidb.io/t/topic/854
- Ref: ti-community-infra/configs#824

Signed-off-by: wuhuizuo <[email protected]>

* chore: update `OWNERS` file

---------

Signed-off-by: wuhuizuo <[email protected]>
baurine added a commit that referenced this pull request Jun 7, 2023
* chore: support skip gen api

* fix: fix skip gen api

* chore: add netlify.toml

* update tidb-dashboard-for-clinic-op

* fix: fix tidb-dashboard-for-clinic-op

* chore: remove authorization header for tidb-dashboard-for-clinic-cloud

* chore: migrate to new prow reviewing (#1510)

* chore: migrate to new prow reviewing

- Backgroup: https://internals.tidb.io/t/topic/854
- Ref: ti-community-infra/configs#824

Signed-off-by: wuhuizuo <[email protected]>

* chore: update `OWNERS` file

---------

Signed-off-by: wuhuizuo <[email protected]>

* fix: make Resource Manager entry show correctly (#1531)

* update version to 2023.06.07.1

---------

Signed-off-by: wuhuizuo <[email protected]>
Co-authored-by: wuhuizuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants