Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid set addr/engine-addr/version/git-hash and HackedLockManager in src/node.rs #139

Merged
merged 10 commits into from
Aug 15, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 8, 2022

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#5170

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo and others added 2 commits August 5, 2022 16:39
@CalvinNeo
Copy link
Member Author

Maybe we should adapt this in 6.3

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Aug 8, 2022

Manual test
image

./tiflash version
TiFlash
Release Version: v6.2.0-alpha-159-gcb31596d7-dirty
Edition:         Community
Git Commit Hash: cb31596d7c7bee776517ec2914637752e09675cf
Git Branch:      HEAD
UTC Build Time:  2022-08-08 04:20:24
Enable Features: avx avx512
Profile:         RelWithDebInfo

Raft Proxy
Git Commit Hash:   603a332ac90cd47d247d8e9219d1a48ac36640a8
Git Commit Branch: HEAD
UTC Build Time:    2022-08-08 04:20:38
Rust Version:      rustc 1.60.0-nightly (1e12aef3f 2022-02-13)
Storage Engine:    tiflash
Prometheus Prefix: tiflash_proxy_
Profile:           debug

image

Please notice that:

  1. Default address and peer_address is defined by TiFlash(namly 3930 and 20170)
  2. Git hash is now proxy's hash
  3. TiFlash can register itself to pd as a special TiKV store and communicate with TiKVs for data replication

PS We hereby provide a previous proxy store as comparison
image

We can also change some addr by modifying tiflash-learner.toml

[server]
addr = "0.0.0.0:30111"
advertise-addr = "127.0.0.1:30111"
engine-addr = "127.0.0.1:3930"
status-addr = "0.0.0.0:30222"
advertise-status-addr = "127.0.0.1:30222"

image

It work fine
image

@CalvinNeo CalvinNeo changed the title Avoid set addr/engine-addr in src/node.rs Avoid set addr/engine-addr and HackedLockManager in src/node.rs Aug 15, 2022
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

components/proxy_server/src/run.rs Show resolved Hide resolved
@CalvinNeo CalvinNeo merged commit 70de535 into pingcap:raftstore-proxy-6.2 Aug 15, 2022
@CalvinNeo
Copy link
Member Author

We need to merge tikv#13234 for TiKV's compat

@CalvinNeo CalvinNeo changed the title Avoid set addr/engine-addr and HackedLockManager in src/node.rs Avoid set addr/engine-addr/version/git-hash and HackedLockManager in src/node.rs Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants