Reclaim TiKV's component server and status server #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
…er-and-status-server-6.2
breezewish
reviewed
Sep 1, 2022
| @@ -220,9 +220,9 @@ pub fn initial_logger(config: &TiKvConfig) { | |||
| pub fn initial_metric(cfg: &MetricConfig) { | |||
| tikv_util::metrics::monitor_process() | |||
| .unwrap_or_else(|e| fatal!("failed to start process monitor: {}", e)); | |||
| tikv_util::metrics::monitor_threads("") | |||
| tikv_util::metrics::monitor_threads("tikv") | |||
There was a problem hiding this comment.
Interesting.. Will this cause metric name changes?
There was a problem hiding this comment.
Well, though we use proxy_server not, but you are right, we should have our own initial_metric...
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
CalvinNeo
force-pushed
the
migrate-remove-component-server-and-status-server-6.2
branch
from
b7a0229
to
6720f60
Compare
…er-and-status-server-6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CalvinNeo [email protected]
What problem does this PR solve?
Issue Number: ref pingcap/tiflash#5170
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note