Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approvers #373

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add approvers #373

merged 2 commits into from
Jun 6, 2024

Conversation

CalvinNeo
Copy link
Member

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


a
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 5, 2024
@CalvinNeo
Copy link
Member Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 5, 2024
@CalvinNeo
Copy link
Member Author

/lgtm

Copy link

ti-chi-bot bot commented Jun 5, 2024

@CalvinNeo: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 5, 2024
Copy link

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 6, 2024
Copy link

ti-chi-bot bot commented Jun 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-05 09:58:44.132042208 +0000 UTC m=+3461677.889177776: ☑️ agreed by zanmato1984.
  • 2024-06-06 02:24:12.609977888 +0000 UTC m=+3520806.367113461: ✖️🔁 reset by CalvinNeo.

Copy link

ti-chi-bot bot commented Jun 6, 2024

New changes are detected. LGTM label has been removed.

@ti-chi-bot ti-chi-bot bot added size/M and removed size/XS labels Jun 6, 2024
@ti-chi-bot ti-chi-bot added the lgtm label Jun 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7906df1 into pingcap:raftstore-proxy Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants