Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

backend/tidb: fix handling of empty binary literals #357

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Jul 22, 2020

What problem does this PR solve?

Fix syntax error on empty binary/hex literals when using TiDB backend.

What is changed and how it works?

Use the x'...' syntax rather than 0x... syntax.

Check List

Tests

  • Integration test

Side effects

Related changes

Release notes

  • Fix syntax error on empty binary/hex literals when using TiDB backend.

@kennytm kennytm added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Jul 22, 2020
@kennytm kennytm force-pushed the kennytm/fix-empty-binary-literals-in-tidb branch from 74a79dd to 277dfd7 Compare July 22, 2020 09:50
@kennytm kennytm marked this pull request as ready for review July 22, 2020 09:52
@kennytm kennytm requested review from glorv and 3pointer July 22, 2020 09:54
@kennytm kennytm changed the title backend: fix handling of empty binary literals backend/tidb: fix handling of empty binary literals Jul 22, 2020
@kennytm kennytm force-pushed the kennytm/fix-empty-binary-literals-in-tidb branch from 277dfd7 to 6a771b5 Compare July 22, 2020 10:29
@kennytm
Copy link
Collaborator Author

kennytm commented Jul 22, 2020

/run-all-tests tikv=release-4.0 tidb=release-4.0 pd=release-4.0 importer=release-4.0

Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glorv glorv added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jul 24, 2020
@kennytm
Copy link
Collaborator Author

kennytm commented Jul 24, 2020

/run-all-tests tikv=release-4.0 tidb=release-4.0 pd=release-4.0 importer=release-4.0

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 24, 2020
@kennytm
Copy link
Collaborator Author

kennytm commented Jul 24, 2020

/run-all-tests tikv=release-4.0 tidb=release-4.0 pd=release-4.0 importer=release-4.0

@kennytm kennytm merged commit aaee763 into master Jul 24, 2020
@kennytm kennytm deleted the kennytm/fix-empty-binary-literals-in-tidb branch July 24, 2020 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants