br: add permission of events to br federation manager (#5156) (#5158)

pingcap · Jul 7, 2023 · 3427a30 · 3427a30
1 parent a5f6b50
commit 3427a30
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/charts/br-federation/templates/controller-manager-rbac.yaml b/charts/br-federation/templates/controller-manager-rbac.yaml
@@ -27,7 +27,7 @@ metadata:
     helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+"  "_" }}
 rules:
 - apiGroups: [""]
-  resources: ["endpoints"]
+  resources: ["endpoints", "events"]
   verbs: ["create", "get", "list", "watch", "update", "delete"]
 - apiGroups: ["federation.pingcap.com"]
   resources: ["*"]

diff --git a/docs/api-references/federation-docs.md b/docs/api-references/federation-docs.md
@@ -1516,7 +1516,7 @@ github.com/pingcap/tidb-operator/pkg/apis/pingcap/v1alpha1.RestoreConditionType
 </em>
 </td>
 <td>
-<p>Phase is the current status of backup member</p>
+<p>Phase is the current status of restore member</p>
 </td>
 </tr>
 <tr>
@@ -1751,7 +1751,7 @@ Kubernetes meta/v1.Time
 </em>
 </td>
 <td>
-<p>TimeStarted is the time at which the restore was started.</p>
+<p>TimeStarted is the time at which the restore step was started.</p>
 </td>
 </tr>
 <tr>
@@ -1764,7 +1764,7 @@ Kubernetes meta/v1.Time
 </em>
 </td>
 <td>
-<p>TimeCompleted is the time at which the restore was completed.</p>
+<p>TimeCompleted is the time at which the restore step was completed.</p>
 </td>
 </tr>
 <tr>
@@ -1775,7 +1775,7 @@ string
 </em>
 </td>
 <td>
-<p>TimeTaken is the time that volume restore federation takes, it is TimeCompleted - TimeStarted</p>
+<p>TimeTaken is the time that all the data planes take, it is TimeCompleted - TimeStarted</p>
 </td>
 </tr>
 </tbody>

diff --git a/pkg/apis/federation/pingcap/v1alpha1/types.go b/pkg/apis/federation/pingcap/v1alpha1/types.go
@@ -394,7 +394,7 @@ type VolumeRestoreMemberStatus struct {
 	TCNamespace string `json:"tcNamespace,omitempty"`
 	// RestoreName is the name of Restore CR
 	RestoreName string `json:"restoreName"`
-	// Phase is the current status of backup member
+	// Phase is the current status of restore member
 	Phase pingcapv1alpha1.RestoreConditionType `json:"phase"`
 	// CommitTs is the commit ts of the restored backup
 	CommitTs string `json:"commitTs,omitempty"`
@@ -407,13 +407,13 @@ type VolumeRestoreMemberStatus struct {
 type VolumeRestoreStep struct {
 	// StepName is the name of volume restore step
 	StepName VolumeRestoreStepType `json:"stepName"`
-	// TimeStarted is the time at which the restore was started.
+	// TimeStarted is the time at which the restore step was started.
 	// +nullable
 	TimeStarted metav1.Time `json:"timeStarted,omitempty"`
-	// TimeCompleted is the time at which the restore was completed.
+	// TimeCompleted is the time at which the restore step was completed.
 	// +nullable
 	TimeCompleted metav1.Time `json:"timeCompleted,omitempty"`
-	// TimeTaken is the time that volume restore federation takes, it is TimeCompleted - TimeStarted
+	// TimeTaken is the time that all the data planes take, it is TimeCompleted - TimeStarted
 	TimeTaken string `json:"timeTaken,omitempty"`
 }