Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Support Graceful Drain for Customized Image Tag #4912

Closed
KanShiori opened this issue Feb 27, 2023 · 0 comments · Fixed by #5173
Closed

Not Support Graceful Drain for Customized Image Tag #4912

KanShiori opened this issue Feb 27, 2023 · 0 comments · Fixed by #5173
Assignees

Comments

@KanShiori
Copy link
Collaborator

Bug Report

What version of Kubernetes are you using?

What version of TiDB Operator are you using?

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

What's the status of the TiDB cluster pods?

What did you do?

What did you expect to see?

What did you see instead?
We use our own internal image tag, TiDB operator version check will fail at https://github.com/pingcap/tidb-operator/blob/v1.4.0/pkg/manager/member/ticdc_scaler.go#L236 with error:

I0224 20:59:23.435983 1 pod_control.go:88] Pod: [tidb/adhoc-ticdc-0] updated successfully, : [tidb/adhoc]
I0224 20:59:23.436013 1 ticdc_scaler.go:323] ticdc.Upgrade: set pod adhoc-ticdc-0 in cluster tidb/adhoc annotation tidb.pingcap.com/ticdc-graceful-shutdown-begin-time to 2023-02-24T20:59:23Z successfully
E0224 20:59:23.444653 1 ticdc_scaler.go:238] ticdc.Upgrade: fail to compare TiCDC pod version "v6.5.0", version "master-1673029844-6fa0cfe0", error: improper constraint: >=master-1673029844-6fa0cfe0, skip graceful shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant