Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to Graceful Drain TiCDC for improper constraint image tag (#5173) #5178

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5173

What problem does this PR solve?

Close #4912

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
    • upgrade TiCDC to a version with improper constraint image tag
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wangle1321 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge July 17, 2023 05:52
@codecov-commenter
Copy link

Codecov Report

Merging #5178 (83092bf) into release-1.4 (9ea4a09) will increase coverage by 0.00%.
The diff coverage is 40.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.4    #5178   +/-   ##
============================================
  Coverage        58.90%   58.91%           
============================================
  Files              227      227           
  Lines            26266    26268    +2     
============================================
+ Hits             15473    15476    +3     
+ Misses            9307     9306    -1     
  Partials          1486     1486           
Flag Coverage Δ
unittest 58.91% <40.00%> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 8d646ab into pingcap:release-1.4 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants