Remove DinD related scripts and document #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! can you remove DinD-related docs in this repo too? |
shonge
changed the title
|
I think the CONTRIBUTING guide also needs to be updated to drop the dind part. |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
Thanks! |
aylei
added a commit
to aylei/tidb-operator
that referenced
this pull request
Dec 7, 2019
Signed-off-by: Aylei <[email protected]> unified grep command for mac and linux (pingcap#1285) Refactor apply Signed-off-by: Aylei <[email protected]> pdapi: only read secret for PD client cert (on TLS enabled clusters) … (pingcap#1290) * pdapi: only read secret for PD client cert (on TLS enabled clusters) when needed * pdapi: adjust log message * pdapi: fix error in logging Remove DinD related scripts and document (pingcap#1283) * Remove DinD related scripts * Remove local-dind-tutorial doc * drop dind part from CONTRIBUTING guide. Fix configmap ownerreference Signed-off-by: Aylei <[email protected]>
cofyc
pushed a commit
that referenced
this pull request
Dec 11, 2019
* sync tidb configmap in controller Signed-off-by: Aylei <[email protected]> unified grep command for mac and linux (#1285) Refactor apply Signed-off-by: Aylei <[email protected]> pdapi: only read secret for PD client cert (on TLS enabled clusters) … (#1290) * pdapi: only read secret for PD client cert (on TLS enabled clusters) when needed * pdapi: adjust log message * pdapi: fix error in logging Remove DinD related scripts and document (#1283) * Remove DinD related scripts * Remove local-dind-tutorial doc * drop dind part from CONTRIBUTING guide. Fix configmap ownerreference Signed-off-by: Aylei <[email protected]> * Use generic_control to perform configmap write Signed-off-by: Aylei <[email protected]> * remove useless code Signed-off-by: Aylei <[email protected]> * Address review comments Signed-off-by: Aylei <[email protected]> * Address review comments Signed-off-by: Aylei <[email protected]> * Refine tidb configmap e2e test Signed-off-by: Aylei <[email protected]> * Address review comments Signed-off-by: Aylei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1156
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: