Before proceeding to initialize TiDB, we wait for the TiDB host:port is open. #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-test |
cofyc
commented
Dec 6, 2019
| - sh | ||
| - -c | ||
| - | | ||
| trap exit TERM |
There was a problem hiding this comment.
able to terminate fast on kill container signal (TERMINAL) (xref: kubernetes/kubernetes#64015 (comment))
There was a problem hiding this comment.
I always run something like dumb-init in my pods so that these issues don't show up
…nto wait-on-tidb-ready
|
/run-e2e-test |
cofyc
requested review from
tennix,
weekface,
breezewish,
aylei and
onlymellb
and removed request for
breezewish
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1255
What is changed and how does it work?
Before proceeding to initialize TiDB, we wait for the TiDB
host:portis open. This avoids unnecessary pod restarts which may result in a very long restart delay (10s, 20s, .., 5 mins).https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy
Check List
Tests
Does this PR introduce a user-facing change?: