Migrate Kubernetes StatefulSet to Advanced StatefulSet automatically #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
commented
Jan 17, 2020
| @@ -704,7 +704,7 @@ var _ = ginkgo.Describe("[tidb-operator] TiDBCluster", func() { | |||
| }) | |||
|
|
|||
| ginkgo.It("should be operable without helm [API]", func() { | |||
| tc := fixture.GetTidbCluster(ns, "plain-cr", "v2.1.16") | |||
| tc := fixture.GetTidbCluster(ns, "plain-cr", utilimage.TiDBV2Version) | |||
There was a problem hiding this comment.
use shared version to reduce the total images we used in e2e
Signed-off-by: Yecheng Fu <[email protected]>
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
aylei
reviewed
Jan 18, 2020
tests/e2e/tidbcluster/serial.go
Outdated
Comment on lines
333
to
338
| defer func() { | ||
| // ginkgo.By("Uninstall tidb-operator") | ||
| // oa.CleanOperatorOrDie(ocfg) | ||
| // ginkgo.By("Uninstalling CRDs") | ||
| // oa.CleanCRDOrDie() | ||
| }() |
There was a problem hiding this comment.
remove this or add a comment
There was a problem hiding this comment.
ah, I should uncomment these lines.
pkg/upgrader/upgrader.go
Outdated
Comment on lines
77
to
83
| klog.Infof("Upgrader: found %d Kubernetes StatefulSets, trying to migrate one by one", len(stsList.Items)) | ||
| for _, sts := range stsList.Items { | ||
| _, err := helper.Upgrade(u.kubeCli, u.asCli, &sts) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| klog.Infof("Upgrader: successfully migrated Kubernetes StatefulSet %s/%s", sts.Namespace, sts.Name) |
There was a problem hiding this comment.
I think we should only migrate statefulset owned by tidbcluster
Signed-off-by: Yecheng Fu <[email protected]>
|
@cofyc Could add some details to explain how |
The Rest LGTM |
|
sure, the basic procedure is like this:
|
|
cherry pick to release-1.1 in PR #1583 |
cofyc
added a commit
that referenced
this pull request
Jan 19, 2020
…1580) (#1583) * Upgrade to Advanced StatefulSet automatically Signed-off-by: Yecheng Fu <[email protected]> * we should only migrate statefulsets owned by tidbcluster Signed-off-by: Yecheng Fu <[email protected]> Co-authored-by: Yecheng Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yecheng Fu [email protected]
What problem does this PR solve?
fixes #1115
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: