tidb-backup: add restoreUsingExistingVolume option (#1708) #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1708 to release-1.1
What problem does this PR solve?
It looks like for ad-hoc backup and restore (at least in the failing test), the helm chart expects the same pvc from the backup to be kept around and used for the subsequent restore. This only works if the source and target clusters are in the same namespace.
I would like to restore to a cluster without any local backups, running on a different Kubernetes cluster in a different region, via S3.
This is split from #1705
What is changed and how does it work?
This adds a
restoreUsingExistingVolumedefaulting totrue. If set tofalse, then a new volume in therestoremode to hold data loaded from s3, gcp, ceph, etc.This option has the same effect as simply setting the mode to
scheduled-restore, but I didn't really understand whatscheduled-restoremeant.Does this PR introduce a user-facing change?: