-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-scaling calculation based by CPU load (#1722) #1726
Merged
Yisaer
merged 17 commits into
pingcap:release-1.1
from
sre-bot:release-1.1-3d54d4796b69
Feb 19, 2020
Merged
Add auto-scaling calculation based by CPU load (#1722) #1726
Yisaer
merged 17 commits into
pingcap:release-1.1
from
sre-bot:release-1.1-3d54d4796b69
Feb 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: DanielZhangQD <[email protected]>
Co-Authored-By: DanielZhangQD <[email protected]>
Co-Authored-By: DanielZhangQD <[email protected]>
Co-Authored-By: DanielZhangQD <[email protected]>
Co-Authored-By: DanielZhangQD <[email protected]>
sre-bot
added
area/auto-scaling
related to auto-scaling
status/PTAL
PR needs to be reviewed
type/1.1 cherry-pick
labels
Feb 19, 2020
sre-bot
requested review from
aylei,
cofyc,
DanielZhangQD,
qiffang and
weekface
February 19, 2020 11:01
Yisaer
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1722 to release-1.1
What problem does this PR solve?
#1651
Adding auto-scaling calculation algorithm based by CPU load.
This request adds the realization of auto-scaling calculation algorithm based by CPU load.
Currently, the auto-scaling is designed to support the cpu AverageUtilization in the following api spec:
notice
To use the auto-scaling by CPU load, the CPU requests in resources must be defined.
What is changed and how does it work?
I would take this spec as an example to explain how the calculation work.
The users create it to claim that the Operator could auto-scale tikv by CPU average load and the threshold value of average Utilization is 80%.
The Operator would query the CPU metrics from Prometheus (currently) to calculate the sum of CPU seconds for each tikv instances in the past 5mins every resync duration seconds.
If the sum of CPU seconds for total tikv instances in the past 5mins is 500 sec as
cpuSecsTotal
The cpu requests in resources is defined as 1 (1000mi) and current replicas of tikv is 3.Related changes
Does this PR introduce a user-facing change?: