Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Tidb Log File Configuration (#2045) #2063

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 30, 2020

cherry-pick #2045 to release-1.1


What problem does this PR solve?

Close #1779

What is changed and how does it work?

Defaulting the Tidb Log File configuration on max-size and max-backups.
For more details about configuration: https://pingcap.com/docs-cn/stable/reference/configuration/tidb-server/configuration-file/#max-backups

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Default the `max-size` and `max-backups` for tidb server configuration with `300` and `3` if the tidb cluster was deployed by CR.

@cofyc cofyc merged commit 83965a5 into pingcap:release-1.1 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants