Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print rclone conf file #2343

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented Apr 29, 2020

What problem does this PR solve?

do not print rclone conf file in the entrypoint

What is changed and how does it work?

do not print rclone conf file in the entrypoint

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Do not print rclone config in the Pod logs

Copy link
Contributor

@shuijing198799 shuijing198799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

Your auto merge job has been accepted, waiting for:

  • 2322
  • 2334

@DanielZhangQD DanielZhangQD merged commit b0af9c9 into pingcap:master Apr 29, 2020
@DanielZhangQD DanielZhangQD deleted the creden branch April 29, 2020 11:21
@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

cherry pick to release-1.1 in PR #2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants