Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CDC Controller #2362

Merged
merged 2 commits into from
May 20, 2020
Merged

Add CDC Controller #2362

merged 2 commits into from
May 20, 2020

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Apr 30, 2020 •
edited
Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Add CDC controller

@weekface weekface changed the title Add cdc controller Add CDC Controller May 15, 2020
@weekface weekface force-pushed the add-cdc-controller branch 2 times, most recently from 3b7010c to 543f9e9 Compare May 18, 2020 06:30
@weekface weekface marked this pull request as ready for review May 18, 2020 10:06
@weekface
Copy link
Contributor Author

/run-e2e-tests

This was referenced May 19, 2020
Closed
Closed
Merged
@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface
Copy link
Contributor Author

/run-all-tests

@weekface
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

Your auto merge job has been accepted, waiting for:

  • 2488

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 25ed92f into pingcap:master May 20, 2020
@weekface weekface deleted the add-cdc-controller branch May 20, 2020 09:01
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 20, 2020
@weekface @sre-bot
Add CDC Controller (pingcap#2362)
eb728b1
@sre-bot sre-bot mentioned this pull request May 20, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-1.1 in PR #2503

sre-bot added a commit that referenced this pull request May 20, 2020
@sre-bot
Add CDC Controller (#2362) (#2503)
719484a
@DanielZhangQD DanielZhangQD mentioned this pull request May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@cofyc cofyc cofyc approved these changes

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weekface @sre-bot @cofyc @Yisaer @DanielZhangQD