fix drainer initialCommitTs issue #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
previously approved these changes
Jul 2, 2020
weekface
commented
Jul 2, 2020
cofyc
previously approved these changes
Jul 6, 2020
|
@cofyc PTAL. |
cofyc
approved these changes
Jul 16, 2020
|
/merge |
|
@cofyc Oops! This PR requires at least 2 LGTMs to merge. The current number of |
cofyc
approved these changes
Jul 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #2857 +/- ##
==========================================
- Coverage 40.91% 40.89% -0.02%
==========================================
Files 153 153
Lines 16748 16748
==========================================
- Hits 6852 6849 -3
- Misses 9354 9356 +2
- Partials 542 543 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-1.0 in PR #2983 |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-1.1 in PR #2984 |
ti-srebot
added a commit
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: weekface <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
initialCommitTsshould be astring, itherwise failed, for example:initialCommitTs: 417774109500375041will be parsed as:What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: