br: ensure pvc names sequential for ebs restore #4888
Conversation
Signed-off-by: WangLe1321 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4888 +/- ##
==========================================
+ Coverage 59.39% 60.49% +1.10%
==========================================
Files 227 231 +4
Lines 25793 28944 +3151
==========================================
+ Hits 15319 17511 +2192
- Misses 9017 9879 +862
- Partials 1457 1554 +97
|
Signed-off-by: WangLe1321 <[email protected]>
Signed-off-by: WangLe1321 <[email protected]>
Signed-off-by: WangLe1321 <[email protected]>
|
/run pull-e2e-kind |
|
/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously |
|
/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial |
|
/test pull-e2e-kind-across-kubernetes |
|
/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial |
|
/test pull-e2e-kind-tngm |
|
/test pull-e2e-kind-across-kubernetes |
|
/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-tngm |
|
/test pull-e2e-kind-tikv-scale-simultaneously |
|
/test pull-e2e-kind |
1 similar comment
|
/test pull-e2e-kind |
|
/test pull-e2e-kind |
1 similar comment
|
/test pull-e2e-kind |
|
/test pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-tikv-scale-simultaneously |
|
/test pull-e2e-kind pull-e2e-kind-br pull-e2e-kind-serial |
|
/test pull-e2e-kind |
2 similar comments
|
/test pull-e2e-kind |
|
/test pull-e2e-kind |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 51886e0
|
|
/test pull-e2e-kind |
3 similar comments
|
/test pull-e2e-kind |
|
/test pull-e2e-kind |
|
/test pull-e2e-kind |
* feat: support tiflash backup and restore during volume snapshot (#4812) * feat: calc the backup size from snapshot storage usage (#4819) * fix backup failed when pod was auto restarted by k8s (#4883) * init code for test * just clean before backup data * delete test code * import pingcap/errors * add check version * remove test code * add running status check * add restart condition to clarify logic * fix status update * fix ut * br: ensure pvc names sequential for ebs restore (#4888) * BR: Restart backup when backup job/pod unexpected failed by k8s (#4895) * init code for test * just clean before backup data * delete test code * import pingcap/errors * add check version * remove test code * add running status check * add restart condition to clarify logic * fix status update * fix ut * init code * update crd reference * fix miss update retry count * add retry limit as constant * init runnable code * refine main controller logic * add some note * address some comments * init e2e test code * add e2e env to extend backup time * add e2e env for test * fix complie * just test kill pod * refine logic * use pkill to kill pod * fix reconcile * add kill pod log * add more log * add more log * try kill pod only * wait and kill running backup pod * add wait for pod failed * fix wait pod running * use killall backup to kill pod * use pkill -9 backup * kill pod until pod is failed * add ps to debug * connect commands by semicolon * kill pod by signal 15 * use panic simulate kill pod * test all kill pod test * remove useless log * add original reason of job or pod failure * rename BackupRetryFailed to BackupRetryTheFailed * BR: Auto truncate log backup in backup schedule (#4904) * init schedule log backup code * add run log backup code * update api * refine some nodes * refine cacluate logic * add ut * fix make check * add log backup test * refine code * fix notes * refine function names * fix conflict * fix: add a new check for encryption during the volume snapshot restore (#4914) * br: volume-snapshot may lead to a panic when there is no block change between two snapshot (#4922) * br: refine BackoffRetryPolicy time format (#4925) * refine BackoffRetryPolicy time format * fix some ut --------- Co-authored-by: fengou1 <[email protected]> Co-authored-by: WangLe1321 <[email protected]>
What problem does this PR solve?
Closes #4884
What is changed and how does it work?
Code changes
Tests
precondition.
according to https://docs.pingcap.com/zh/tidb-in-kubernetes/stable/advanced-statefulset, upgrade tide-operator with asts.
case#1
case#2
create a cluster with 6 nodes
scale out the cluster to 9 nodes
scale in the cluster to 6 nodes, and set delete-slots [3,4,5]
remove released existing pv/pvcs and then do the backup
restore the backup
No code
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.