Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump operator version to 1.4.3 #4890

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Feb 20, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #4890 (2869188) into release-1.4 (8791566) will increase coverage by 8.57%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4    #4890      +/-   ##
===============================================
+ Coverage        59.91%   68.48%   +8.57%     
===============================================
  Files              224      228       +4     
  Lines            25333    28375    +3042     
===============================================
+ Hits             15177    19434    +4257     
+ Misses            8722     7491    -1231     
- Partials          1434     1450      +16     
Flag Coverage Δ
e2e 52.97% <ø> (?)
unittest 59.91% <ø> (+<0.01%) ⬆️

@KanShiori
Copy link
Collaborator Author

/run-all-tests

@KanShiori KanShiori closed this Feb 20, 2023
@KanShiori KanShiori reopened this Feb 20, 2023
@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-br pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-basic pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-basic

@KanShiori
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@KanShiori: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@KanShiori: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@KanShiori
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@KanShiori: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@KanShiori KanShiori merged commit f3fe4df into pingcap:release-1.4 Feb 21, 2023
@KanShiori KanShiori deleted the shiori/bump-v1.4.3 branch February 21, 2023 07:31
@KanShiori KanShiori mentioned this pull request Feb 23, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants