Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: implement federation volume backup controller #5013

Merged
merged 13 commits into from
May 31, 2023
Merged

br: implement federation volume backup controller #5013

merged 13 commits into from
May 31, 2023

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented May 18, 2023 •
edited by zhangjinpeng87
Loading

What problem does this PR solve?

implement federation volume backup controller to execute volume backup across multiple k8s clusters.

Close #5012

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BornChanger
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from csuzhangxc and handlerww May 18, 2023 02:44
@WangLe1321 WangLe1321 changed the title br: implement federation volume backup controller [WIP] br: implement federation volume backup controller May 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #5013 (e1197e6) into master (50456b0) will increase coverage by 8.54%.
The diff coverage is 42.04%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5013      +/-   ##
==========================================
+ Coverage   57.01%   65.56%   +8.54%     
==========================================
  Files         243      249       +6     
  Lines       27484    31419    +3935     
==========================================
+ Hits        15671    20601    +4930     
+ Misses      10280     9222    -1058     
- Partials     1533     1596      +63
Flag Coverage Δ
e2e 50.24% <0.00%> (?)
unittest 57.25% <43.91%> (+0.23%) ⬆️

@BornChanger BornChanger mentioned this pull request May 18, 2023
Open
@WangLe1321 WangLe1321 changed the title [WIP] br: implement federation volume backup controller br: implement federation volume backup controller May 29, 2023
BornChanger
BornChanger approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit test cases similar to the data plane backup controller. Others LGTM

csuzhangxc
csuzhangxc approved these changes May 30, 2023
View reviewed changes
pkg/fedvolumebackup/backup/backup_manager.go
Comment on lines +157 to +158
if err := kubeClient.PingcapV1alpha1().Backups(backupMember.backup.Namespace).
Delete(ctx, backupMember.backup.Name, metav1.DeleteOptions{}); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to wait for the backup in the data plane deletion is complete?

Copy link
Contributor Author

@WangLe1321 WangLe1321 May 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think waiting for the backup in the data plane deletion complete is better. If the backup in data plane cleanup failed, we shouldn't delete the volume backup in control plane,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, will you add a TODO here?

@WangLe1321
Copy link
Contributor Author

test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind-basic pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-tngm

@WangLe1321
Copy link
Contributor Author

/test pull-e2e-kind-basic pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-tngm

@WangLe1321
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e1197e6

@ti-chi-bot ti-chi-bot bot merged commit 2da77b8 into pingcap:master May 31, 2023
@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5135.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Jul 4, 2023
@ti-chi-bot @WangLe1321
br: implement federation volume backup controller (#5013) (#5135)
02a6397 
Signed-off-by: WangLe1321 <[email protected]>
Co-authored-by: WangLe1321 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the size/XXL label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@BornChanger BornChanger BornChanger approved these changes

@handlerww handlerww Awaiting requested review from handlerww

Assignees
No one assigned
Labels
area/ebs-br size/XXL status/can-merge status/LGT2 type/cherry-pick-for-release-1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement volume backup federation controller
5 participants
@WangLe1321 @codecov-commenter @BornChanger @ti-chi-bot @csuzhangxc