fix(volume): fix panic bug when enable ModifyVolume feature #5058

liubog2008 · 2023-06-09T08:10:59Z

What problem does this PR solve?

Fix #4990
Fix #5011

What is changed and how does it work?

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

csuzhangxc · 2023-06-12T14:58:55Z

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-12T14:58:57Z

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-12T14:58:57Z

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov-commenter · 2023-06-12T16:06:13Z

Codecov Report

Merging #5058 (258f3a9) into master (3092372) will increase coverage by 8.08%.
The diff coverage is 72.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5058      +/-   ##
==========================================
+ Coverage   57.36%   65.44%   +8.08%     
==========================================
  Files         246      250       +4     
  Lines       28587    31956    +3369     
==========================================
+ Hits        16398    20915    +4517     
+ Misses      10595     9408    -1187     
- Partials     1594     1633      +39

Flag	Coverage Δ
e2e	`49.83% <53.53%> (?)`
unittest	`57.44% <41.93%> (+0.08%)`	⬆️

hanlins

LGTM

ti-chi-bot · 2023-06-12T22:02:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, hanlins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [csuzhangxc,hanlins]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hanlins · 2023-06-12T22:03:12Z

/test pull-e2e-kind

ti-chi-bot · 2023-06-12T22:03:14Z

@hanlins: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-12T22:03:14Z

@hanlins: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-06-13T02:27:18Z

[LGTM Timeline notifier]

Timeline:

2023-06-12 14:59:32.460309887 +0000 UTC m=+11368.874913963: ☑️ agreed by csuzhangxc.
2023-06-13 02:27:17.408061103 +0000 UTC m=+52633.822665182: ✖️🔁 reset by ti-chi-bot[bot].

ti-chi-bot · 2023-06-13T02:27:19Z

New changes are detected. LGTM label has been removed.

csuzhangxc · 2023-06-20T06:24:03Z

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

ti-chi-bot · 2023-06-20T06:24:05Z

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T06:24:05Z

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

csuzhangxc · 2023-06-20T06:51:24Z

/test pull-e2e-kind

ti-chi-bot · 2023-06-20T06:51:26Z

@csuzhangxc: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T06:51:26Z

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

csuzhangxc · 2023-06-20T07:05:38Z

/test pull-e2e-kind

ti-chi-bot · 2023-06-20T07:05:40Z

@csuzhangxc: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T07:05:40Z

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

csuzhangxc · 2023-06-20T07:31:52Z

/test pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-20T07:31:53Z

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T07:31:54Z

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

csuzhangxc · 2023-06-20T09:07:30Z

/test pull-e2e-kind-tngm
/test pull-e2e-kind-tikv-scale-simultaneously

ti-chi-bot · 2023-06-20T09:07:32Z

@csuzhangxc: The label(s) /pull-e2e-kind-tngm, /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tngm
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T09:07:33Z

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-tngm
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

csuzhangxc · 2023-06-20T10:08:33Z

/merge

csuzhangxc · 2023-06-20T10:09:20Z

/cherry-pick release-1.5

ti-chi-bot · 2023-06-20T10:09:22Z

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T10:09:22Z

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc · 2023-06-20T10:09:31Z

/cherry-pick release-1.4

ti-chi-bot · 2023-06-20T10:09:32Z

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.4 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T10:09:33Z

@csuzhangxc: The label(s) /release-1.4 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-20T10:11:33Z

@hanlins: new pull request created to branch release-1.4: #5082.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2023-06-20T10:12:12Z

@hanlins: new pull request created to branch release-1.5: #5083.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…5082) Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: Bo Liu <[email protected]> Co-authored-by: csuzhangxc <[email protected]>

…5083) Co-authored-by: liubo02 <[email protected]>

ti-chi-bot bot added the size/L label Jun 9, 2023

ti-chi-bot bot requested review from howardlau1999 and shonge June 9, 2023 08:11

liubog2008 mentioned this pull request Jun 9, 2023

tidb-controller-manager panics if tidb-cluster is configured with AdditionalVolumeMounts #5011

Closed

liubog2008 force-pushed the fix-panic branch 2 times, most recently from 17ca051 to 2ca8ca7 Compare June 9, 2023 08:47

ti-chi-bot bot added size/XL and removed size/L labels Jun 9, 2023

liubog2008 added 4 commits June 12, 2023 14:19

fix(volume): fix panic bug when enable ModifyVolume feature

4d9cdb1

fix(volume): skip delegated modifier if sc is not changed

266d0e4

fix misspell

6d746cf

fix test

51e09c5

liubog2008 force-pushed the fix-panic branch from b6f12e1 to 51e09c5 Compare June 12, 2023 06:19

csuzhangxc approved these changes Jun 12, 2023

View reviewed changes

ti-chi-bot bot added lgtm approved labels Jun 12, 2023

hanlins approved these changes Jun 12, 2023

View reviewed changes

Merge branch 'master' into fix-panic

4460846

ti-chi-bot bot removed the lgtm label Jun 13, 2023

Merge branch 'master' into fix-panic

9badc45

csuzhangxc merged commit 0015c82 into pingcap:master Jun 20, 2023

ti-chi-bot mentioned this pull request Jun 20, 2023

fix(volume): fix panic bug when enable ModifyVolume feature (#5058) #5082

Merged

10 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Jun 20, 2023

This is an automated cherry-pick of pingcap#5058

816759d

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Jun 20, 2023

fix(volume): fix panic bug when enable ModifyVolume feature (#5058) #5083

Merged

10 tasks

csuzhangxc pushed a commit that referenced this pull request Jun 23, 2023

fix(volume): fix panic bug when enable ModifyVolume feature (#5058) (#…

3dc9543

…5083) Co-authored-by: liubo02 <[email protected]>

fix(volume): fix panic bug when enable ModifyVolume feature #5058

fix(volume): fix panic bug when enable ModifyVolume feature #5058

Conversation

liubog2008 commented Jun 9, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

csuzhangxc commented Jun 12, 2023

ti-chi-bot bot commented Jun 12, 2023

ti-chi-bot bot commented Jun 12, 2023

codecov-commenter commented Jun 12, 2023 • edited Loading

Codecov Report

hanlins left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Jun 12, 2023

hanlins commented Jun 12, 2023

ti-chi-bot bot commented Jun 12, 2023

ti-chi-bot bot commented Jun 12, 2023

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

ti-chi-bot bot commented Jun 13, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

csuzhangxc commented Jun 20, 2023

ti-chi-bot commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023

ti-chi-bot commented Jun 20, 2023

ti-chi-bot commented Jun 20, 2023

liubog2008 commented Jun 9, 2023 •

edited

Loading

codecov-commenter commented Jun 12, 2023 •

edited

Loading