Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: upgrade ticdc first if version >= v5.1.0 #5140

Closed
wants to merge 22 commits into from

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jul 4, 2023

What problem does this PR solve?

close #4966

What is changed and how does it work?

upgrade ticdc first if version >= v5.1.0

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • Manual test

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Upgrade ticdc first if its version is bigger than or equal to v5.1.0

@ti-chi-bot ti-chi-bot bot requested a review from shonge July 4, 2023 06:54
@Rustin170506 Rustin170506 marked this pull request as ready for review July 4, 2023 08:22
@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu July 4, 2023 08:22
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Jul 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #5140 (b240949) into master (af4c23a) will increase coverage by 6.97%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5140      +/-   ##
==========================================
+ Coverage   57.24%   64.22%   +6.97%     
==========================================
  Files         247      251       +4     
  Lines       29872    33386    +3514     
==========================================
+ Hits        17101    21441    +4340     
+ Misses      11107    10212     -895     
- Partials     1664     1733      +69     
Flag Coverage Δ
e2e 47.08% <64.28%> (?)
unittest 57.25% <63.63%> (+<0.01%) ⬆️

Signed-off-by: hi-rustin <[email protected]>

ticdc: add tests

Signed-off-by: hi-rustin <[email protected]>

ticdc: add more tests

Signed-off-by: hi-rustin <[email protected]>

ticdc: rename

Signed-off-by: hi-rustin <[email protected]>

ticdc: add deps ro controller

Signed-off-by: hi-rustin <[email protected]>

ticdc: use correct version

Signed-off-by: hi-rustin <[email protected]>

ticdc: add test for GetImageVersion

Signed-off-by: hi-rustin <[email protected]>

br: GC by MaxReservedTime works on completed or failed backups (pingcap#5148)
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506
Copy link
Member Author

/run-all-tests

Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check

Signed-off-by: hi-rustin <[email protected]>
@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

https://ci.pingcap.net/blue/organizations/jenkins/tidb-operator-pull-e2e-kind-serial/detail/tidb-operator-pull-e2e-kind-serial/4149/tests/

when upgrading the TiDB cluster (with 1 PD), the process was blocked as TiCDC waited for PD ready but PD's status stayed in Upgrade.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to customize the upgrade sequence for different versions of a component?
4 participants