Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change scope of feat VolumeModifying #5167

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Jul 12, 2023

What problem does this PR solve?

Change the scope of feature VolumeModifying.

Now even if we disable the feature VolumeModifying, volume resizing will also be worked.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu July 12, 2023 07:32
@ti-chi-bot ti-chi-bot bot added the size/M label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-14 08:12:27.774754435 +0000 UTC m=+665239.545093391: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5167 (8018b11) into master (ed5fba3) will decrease coverage by 0.01%.
The diff coverage is 64.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5167      +/-   ##
==========================================
- Coverage   57.98%   57.98%   -0.01%     
==========================================
  Files         248      248              
  Lines       29330    29329       -1     
==========================================
- Hits        17008    17005       -3     
- Misses      10678    10679       +1     
- Partials     1644     1645       +1     
Flag Coverage Δ
unittest 57.98% <64.28%> (-0.01%) ⬇️

@csuzhangxc csuzhangxc merged commit df734da into pingcap:master Jul 14, 2023
@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

@csuzhangxc: The label(s) /release-1.4 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5171.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.4: #5172.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants