Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebs br: support specification of iops, bandwidth and type of restored volumes #5175

Closed
wants to merge 3 commits into from
Closed

ebs br: support specification of iops, bandwidth and type of restored volumes #5175

wants to merge 3 commits into from

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jul 15, 2023 •
edited
Loading

What problem does this PR solve?

Close #5174

What is changed and how does it work?

This feature enables specification of iops, bandwidth and type of restored volumes.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 July 15, 2023 14:13
@ti-chi-bot ti-chi-bot bot added the size/L label Jul 15, 2023
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

BornChanger commented Jul 15, 2023 •
edited
Loading

/cc @WangLe1321 @csuzhangxc PTAL.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /@wangle1321, /@csuzhangxc, /ptal. cannot be applied, because the repository doesn't have them.

In response to this:

/assign @WangLe1321 @csuzhangxc PTAL.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /@wangle1321, /@csuzhangxc, /ptal. cannot be applied, because the repository doesn't have them.

In response to this:

/cc @WangLe1321 @csuzhangxc PTAL.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/cc @WangLe1321

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /@wangle1321 cannot be applied, because the repository doesn't have them.

In response to this:

/cc @WangLe1321

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot requested a review from WangLe1321 July 15, 2023 14:15
@BornChanger
Copy link
Contributor Author

/cc @csuzhangxc

@ti-chi-bot ti-chi-bot bot requested a review from csuzhangxc July 15, 2023 14:15
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /@csuzhangxc cannot be applied, because the repository doesn't have them.

In response to this:

/cc @csuzhangxc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #5175 (525ab02) into master (df734da) will increase coverage by 7.29%.
The diff coverage is 40.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5175      +/-   ##
==========================================
+ Coverage   57.96%   65.26%   +7.29%     
==========================================
  Files         248      252       +4     
  Lines       29329    32780    +3451     
==========================================
+ Hits        17002    21395    +4393     
+ Misses      10681     9649    -1032     
- Partials     1646     1736      +90
Flag Coverage Δ
e2e 46.23% <30.00%> (?)
unittest 57.95% <30.00%> (-0.02%) ⬇️

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger changed the title ebs br: support specification of iops, bandwidth and type of restored… ebs br: support specification of iops, bandwidth and type of restored volumes Jul 15, 2023
@BornChanger BornChanger mentioned this pull request Jul 15, 2023
Open
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Jul 15, 2023
@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2023

@BornChanger: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-basic pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

@BornChanger: The label(s) /pull-e2e-kind-basic, /pull-e2e-kind-serial, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-basic pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

Close it since we can specify those parameters in BR template options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

@WangLe1321 WangLe1321 Awaiting requested review from WangLe1321

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebs br: support to specify iops, bandwidth and type for restored volumes
3 participants
@BornChanger @ti-chi-bot @codecov-commenter