br: modify to use one kubeconfig for multiple data planes #5186

WangLe1321 · 2023-07-20T10:21:06Z

What problem does this PR solve?

Modify to use one kubeconfig for multiple data planes

What is changed and how does it work?

Change the flag federation-kubeconfig-path to the kubeconfig file path. Then read the kubeconfig file and use the contexts in kubeconfig file mapping to the data planes

After this change, the secret that stores the kubeconfig file should be configured like this:

apiVersion: v1
kind: Secret
metadata:
  name: br-federation-kubeconfig
type: Opaque
data:
  kubeconfig: {encoded-kubeconfig}

If the user want to use custom secret name or custom data key, he should change the value of chart .brFederationManager.federationKubeconfigSecret or .brFederationManager.federationKubeconfigSecretKey

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Signed-off-by: WangLe1321 <[email protected]>

codecov-commenter · 2023-07-20T10:41:55Z

Codecov Report

Merging #5186 (4f37860) into master (f838c88) will decrease coverage by 24.23%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #5186       +/-   ##
===========================================
- Coverage   57.98%   33.76%   -24.23%     
===========================================
  Files         245      208       -37     
  Lines       29240    27685     -1555     
===========================================
- Hits        16954     9347     -7607     
- Misses      10639    17115     +6476     
+ Partials     1647     1223      -424

Flag	Coverage Δ
e2e	`33.76% <0.00%> (?)`
unittest	`?`

WangLe1321 · 2023-07-27T03:22:27Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

ti-chi-bot · 2023-07-27T03:22:28Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T03:22:28Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

charts/br-federation/values.yaml

Signed-off-by: WangLe1321 <[email protected]>

WangLe1321 · 2023-07-27T03:54:32Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

ti-chi-bot · 2023-07-27T03:54:33Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T03:54:34Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-27T06:20:11Z

/test pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-07-27T06:20:13Z

@WangLe1321: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T06:20:13Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-27T06:41:32Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

ti-chi-bot · 2023-07-27T06:41:34Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T06:41:34Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-27T06:55:53Z

/test pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-07-27T06:55:54Z

@WangLe1321: The label(s) /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T06:55:55Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-27T08:52:44Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br

ti-chi-bot · 2023-07-27T08:52:46Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T08:52:46Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-27T13:46:42Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-07-27T13:46:43Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T13:46:43Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-27T13:47:39Z

/test pull-e2e-kind-across-kubernetes pull-e2e-kind

ti-chi-bot · 2023-07-27T13:47:41Z

@WangLe1321: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-27T13:47:41Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-07-28T03:14:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BornChanger,csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-07-28T03:14:52Z

[LGTM Timeline notifier]

Timeline:

2023-07-27 03:44:22.002861652 +0000 UTC m=+412404.597392642: ☑️ agreed by BornChanger.
2023-07-27 03:51:50.157058515 +0000 UTC m=+412852.751589503: ✖️🔁 reset by WangLe1321.
2023-07-28 03:14:51.900127404 +0000 UTC m=+497034.494658408: ☑️ agreed by csuzhangxc.

WangLe1321 · 2023-07-28T03:22:05Z

/cherry-pick release-1.5

ti-chi-bot · 2023-07-28T03:22:06Z

@WangLe1321: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-28T03:22:40Z

@WangLe1321: new pull request created to branch release-1.5: #5209.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

) Signed-off-by: WangLe1321 <[email protected]> Co-authored-by: WangLe1321 <[email protected]>

br: modify to use one kubeconfig for multiple data planes

a585099

Signed-off-by: WangLe1321 <[email protected]>

ti-chi-bot bot requested a review from shonge July 20, 2023 10:21

ti-chi-bot bot added the size/S label Jul 20, 2023

WangLe1321 added area/ebs-br type/cherry-pick-for-release-1.5 labels Jul 20, 2023

BornChanger mentioned this pull request Jul 24, 2023

EBS BR support to multiple k8s cluster TiDB #5003

Open

Merge branch 'master' into feat/br-fed-merge-kubeconfig

65b5e32

BornChanger requested review from csuzhangxc and BornChanger and removed request for shonge July 27, 2023 03:29

BornChanger reviewed Jul 27, 2023

View reviewed changes

charts/br-federation/values.yaml Show resolved Hide resolved

BornChanger approved these changes Jul 27, 2023

View reviewed changes

ti-chi-bot bot added lgtm approved labels Jul 27, 2023

br: add comments to values.yaml

ca843b0

Signed-off-by: WangLe1321 <[email protected]>

ti-chi-bot bot removed the lgtm label Jul 27, 2023

ti-chi-bot bot added 2 commits July 27, 2023 06:21

Merge branch 'master' into feat/br-fed-merge-kubeconfig

6d6cc36

Merge branch 'master' into feat/br-fed-merge-kubeconfig

4f37860

csuzhangxc approved these changes Jul 28, 2023

View reviewed changes

ti-chi-bot bot added the lgtm label Jul 28, 2023

ti-chi-bot bot merged commit a0ef530 into pingcap:master Jul 28, 2023
4 of 5 checks passed

ti-chi-bot mentioned this pull request Jul 28, 2023

br: modify to use one kubeconfig for multiple data planes (#5186) #5209

Merged

10 tasks

csuzhangxc pushed a commit that referenced this pull request Jul 28, 2023

br: modify to use one kubeconfig for multiple data planes (#5186) (#5209

2021292

) Signed-off-by: WangLe1321 <[email protected]> Co-authored-by: WangLe1321 <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

br: modify to use one kubeconfig for multiple data planes #5186

br: modify to use one kubeconfig for multiple data planes #5186

WangLe1321 commented Jul 20, 2023 •

edited

Loading

codecov-commenter commented Jul 20, 2023 •

edited

Loading

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 28, 2023

ti-chi-bot bot commented Jul 28, 2023

WangLe1321 commented Jul 28, 2023

ti-chi-bot bot commented Jul 28, 2023

ti-chi-bot commented Jul 28, 2023

br: modify to use one kubeconfig for multiple data planes #5186

br: modify to use one kubeconfig for multiple data planes #5186

Conversation

WangLe1321 commented Jul 20, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

codecov-commenter commented Jul 20, 2023 • edited Loading

Codecov Report

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

WangLe1321 commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 27, 2023

ti-chi-bot bot commented Jul 28, 2023

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

WangLe1321 commented Jul 28, 2023

ti-chi-bot bot commented Jul 28, 2023

ti-chi-bot commented Jul 28, 2023

WangLe1321 commented Jul 20, 2023 •

edited

Loading

codecov-commenter commented Jul 20, 2023 •

edited

Loading