Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: make snapshot size calculation optional (#5202) #5214

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5202

What problem does this PR solve?

Close #5201
Close #5212

What is changed and how does it work?

This pr introduced an option 'calcSizeLevel' in backup spec to claim if calculate backup snapshot size or not, and calculate which part of snapshot sizes.

  • 'all' (default) : calculate both full and incremental size; ''
  • 'full' : calculate full size
  • 'incremental': calculate incremental size
  • 'disabled': skip size calculation
apiVersion: pingcap.com/v1alpha1
kind: Backup
metadata:
  name: zm-dataplane-a
  namespace: backup-a
spec:
  backoffRetryPolicy:
    maxRetryTimes: 2
    minRetryDuration: 300s
    retryTimeout: 30m
  backupMode: volume-snapshot
  backupType: full
  br:
    cluster: db-a
    clusterNamespace: backup-a
    sendCredToTikv: false
  cleanPolicy: Delete
  calcSizeLevel: disabled | full | incremental | all
  resources: {}
  s3:
    bucket: wangle-ebs-test-us-west-2
    prefix: backup-20230704
    provider: aws
    region: us-west-2
  serviceAccount: tidb-backup-manager

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit d6bd886 into pingcap:release-1.5 Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants