Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow porting labels to restore pod #5349

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Allow porting labels to restore pod #5349

merged 2 commits into from
Oct 20, 2023

Conversation

olivia-chen-github
Copy link
Contributor

@olivia-chen-github olivia-chen-github commented Oct 20, 2023

Allow porting labels to restore pod

What problem does this PR solve?

Allow porting labels to restore pod

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #5349 (bea8fd6) into master (bbb73c5) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5349      +/-   ##
==========================================
+ Coverage   61.60%   61.91%   +0.30%     
==========================================
  Files         228      239      +11     
  Lines       28858    32605    +3747     
==========================================
+ Hits        17779    20187    +2408     
- Misses       9337    10577    +1240     
- Partials     1742     1841      +99     
Flag Coverage Δ
e2e 22.37% <ø> (?)
unittest 61.59% <100.00%> (-0.02%) ⬇️

@csuzhangxc
Copy link
Member

@WangLe1321 PTAL

Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind-br

@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 20, 2023
@BornChanger
Copy link
Contributor

/cc @WangLe1321

@ti-chi-bot ti-chi-bot bot requested a review from WangLe1321 October 20, 2023 08:16
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 08:13:08.256507717 +0000 UTC m=+1990385.843617855: ☑️ agreed by BornChanger.
  • 2023-10-20 08:14:00.65675075 +0000 UTC m=+1990438.243860897: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-10-20 08:18:09.06062911 +0000 UTC m=+1990686.647739255: ☑️ agreed by WangLe1321.

@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc merged commit efb9250 into pingcap:master Oct 20, 2023
7 checks passed
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5350.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nkg-
Copy link
Contributor

nkg- commented Oct 23, 2023

Linking blame PR - #5247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants