-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always save checkpoint to the warmup folder #5507
Conversation
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
/retest |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
- Coverage 61.32% 61.32% -0.01%
==========================================
Files 234 234
Lines 29985 29996 +11
==========================================
+ Hits 18388 18394 +6
- Misses 9758 9760 +2
- Partials 1839 1842 +3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
/cherry-pick release-1.5 |
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Fixed #5506.
What is changed and how does it work?
The checkpoint file is stored at the work directory where the
warmup
binary runs. And in most cases, it is/
and won't be persisted to a PV.This PR changes the
warmup_step
script, make it always set checkpoint to the directory to be warmed up(Which is probably a real EBS disk).(Also notice that, it is impossible to pass a glob pattern to
warmup_step
anymore.)Code changes
Tests
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.