Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add metrics for volume backup (#5534) #5545

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5534

What problem does this PR solve?

Add metrics for br federation manager

Closes #5533

What is changed and how does it work?

Add metrics about volume backup status, volume backup total time, volume backup total size, volume backup cleanup status and volume backup cleanup total time.

For volume backup cleanup, there is no status to indicate cleanup failed. So I also add a CleanFailed status to backup and volume backup. If backup cleanup is failed, the backup CR will become CleanFailed status. If one of backup cleanup in data plane is failed, the volume backup CR will become CleanFailed status.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

image

image

image

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-07 12:25:55.891407563 +0000 UTC m=+359681.458177445: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 7, 2024
@BornChanger
Copy link
Contributor

/retest

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (456a027) 61.64% compared to head (49b3ab5) 67.92%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5545      +/-   ##
===============================================
+ Coverage        61.64%   67.92%   +6.28%     
===============================================
  Files              228      242      +14     
  Lines            29151    33149    +3998     
===============================================
+ Hits             17969    22518    +4549     
+ Misses            9420     8825     -595     
- Partials          1762     1806      +44     
Flag Coverage Δ
e2e 47.81% <38.09%> (?)
unittest 61.60% <48.21%> (-0.04%) ⬇️

@csuzhangxc csuzhangxc merged commit d22f4cc into pingcap:release-1.5 Feb 8, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants