-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: support k3s as provider for local-up #5727
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hack/local-up-operator.sh
Outdated
|
||
Usage: hack/local-up-operator.sh [-hd] | ||
Usage: router.sh [-hd] [-p PROVIDER] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to rename this file to router.sh
? or just use hack/local-up-operator.sh
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overlooked this.
Maybe local-up-operator.sh
is a better name, it could keep the reference consistent, if someone do referenced it.
/run-pull-e2e-kind-basic |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5727 +/- ##
===========================================
- Coverage 61.47% 21.47% -40.01%
===========================================
Files 235 219 -16
Lines 30653 30626 -27
===========================================
- Hits 18843 6576 -12267
- Misses 9920 23068 +13148
+ Partials 1890 982 -908
|
/run-pull-e2e-kind-basic |
/cherry-pick release-1.6 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Co-authored-by: RidRisR <[email protected]>
What problem does this PR solve?
Add a new script to use k3s as k8s cluster provider and install tidb-operator
Add a new script to route between kind and k3s
What is changed and how does it work?
Add a new script to use k3s as k8s cluster provider and install tidb-operator
Add a new script to route between kind and k3s
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.